Update JS & Add styles #11
Conversation
README.md
Outdated
| web3.currentProvider, | ||
| "ropsten" | ||
| ); | ||
| (async () => await provider.send("eth_requestAccounts", []))(); |
There was a problem hiding this comment.
Do you mind changing this to use .then() instead of anonymous async-await so as to make it easier for beginners to understand.
There was a problem hiding this comment.
I can do that but I could also just change the script tag to be <script type="module"> so top-level await is able to be used, which would make it easier to understand, while also being more up-to-date JavaScript. I'm not good at deciding which is better for newer developers, what do you recommend?
There was a problem hiding this comment.
@haardikk21 check my latest commits, I made it use .then :)
There was a problem hiding this comment.
i prefer async/await, but my sole concern here is with the anonymous function. having to do (async () => await ...)() is weird unless you understand it, thats why i suggested .then
thank you!
There was a problem hiding this comment.
please let me know your Discord username so I can give you your role
Changed some code to use up-to-date JavaScript and Ethers, as
varis widely considered to be obsolete, and Ether's was giving warnings in console since the code was using outdated functions. I also added an optional step to add some styles to the code.