Skip to content

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Jul 25, 2023

This will not pass out-of-tree checks until the llvm-18 packages are available on apt.llvm.org

We might also want to hold off merging this until all remaining opaque pointer changes are in (to avoid having to cherry-pick them)?

@svenvh svenvh requested a review from MrSidims July 25, 2023 13:40
@MrSidims
Copy link
Contributor

Yeah, lets wait until end of week for the merge

@MrSidims
Copy link
Contributor

MrSidims commented Aug 2, 2023

@svenvh probably all the required patches are merged

@svenvh
Copy link
Member Author

svenvh commented Aug 2, 2023

Alright, I've created the llvm_release_170 branch now. We can't merge this PR yet, since the apt packages for llvm-18 aren't there yet.

@svenvh
Copy link
Member Author

svenvh commented Aug 2, 2023

We can't merge this PR yet, since the apt packages for llvm-18 aren't there yet.

... although everyone needs the CMakeLists.txt changes to build with llvm's main. @MrSidims any preference if we merge it now, or should we separate out the CMakeLists.txt version bump (or any other ideas)?

@MrSidims
Copy link
Contributor

MrSidims commented Aug 2, 2023

We can't merge this PR yet, since the apt packages for llvm-18 aren't there yet.

... although everyone needs the CMakeLists.txt changes to build with llvm's main. @MrSidims any preference if we merge it now, or should we separate out the CMakeLists.txt version bump (or any other ideas)?

wouldn't https://apt.llvm.org/focal/dists/llvm-toolchain-focal/main/ contain llvm-18 already? My expectation that reverting #2104 should make CI working

@svenvh
Copy link
Member Author

svenvh commented Aug 2, 2023

wouldn't https://apt.llvm.org/focal/dists/llvm-toolchain-focal/main/ contain llvm-18 already? My expectation that reverting #2104 should make CI working

Ah, I think you may be right. Let's merge this and revert #2104 then? :-)

@svenvh svenvh merged commit 3b3e903 into KhronosGroup:main Aug 2, 2023
@svenvh svenvh deleted the llvm18 branch August 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants