Skip to content

🐛Find-LocalModule min comparison using wrong logic #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

🐛Find-LocalModule min comparison using wrong logic #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ModuleFast.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,11 +1816,11 @@ function Find-LocalModule {

#We can fast filter items that are below the lower bound, we dont need to read these manifests
if ($ModuleSpec.Min) {
#HACK: Nuget does not correctly convert major.minor.build versions.
#HACK: Nuget does not correctly convert major.minor.build versions
[version]$originalBaseVersion = ($modulespec.Min.OriginalVersion -split '-')[0]
[Version]$minVersion = $originalBaseVersion.Revision -eq -1 ? $originalBaseVersion : $ModuleSpec.Min.Version
if ($minVersion -lt $ModuleSpec.Min.OriginalVersion) {
Write-Debug "${ModuleSpec}: Skipping $folder - below the lower bound"
if ($version -lt $minVersion) {
Write-Debug "${ModuleSpec}: Skipping $folder - $version is below the lower bound of $minVersion"
return
}
}
Expand Down
8 changes: 8 additions & 0 deletions ModuleFast.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,14 @@ Describe 'Get-ModuleFastPlan' -Tag 'E2E' {
}
ModuleName = 'PrereleaseTest'
},
@{
Spec = 'PrereleaseTest>=0.0.1-prerelease'
Check = {
$actual.Name | Should -Be 'PrereleaseTest'
$actual.ModuleVersion | Should -Be '0.0.2-prerelease'
}
ModuleName = 'PrereleaseTest'
},
@{
Spec = 'PrereleaseTest:*'
ModuleName = 'PrereleaseTest'
Expand Down