Add global configmap #431
Merged
Add global configmap #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
kerthcet
force-pushed
the
cleanup/fix-config
branch
from
5ba3796 to
99d9f57
Compare
googs1025
reviewed
Jun 1, 2025
|
|
||
| logger.V(10).Info("reconcile Service", "Service", klog.KObj(service)) | ||
|
|
||
| cm := &corev1.ConfigMap{} |
There was a problem hiding this comment.
I have a question here 🤔 : Do we need to get cm obj every time we reconcile? Or can we use event triggering? Because I understand that cm will not be modified in most cases, it seems meaningless to get it every time in Reconcile. But this is not a blocking item but more of an optimization item. If it is due to the code width problem, I can submit a PR to optimize this part in the near future.
There was a problem hiding this comment.
Anyway, it's not a big problem. We can optimize this later.
kerthcet
force-pushed
the
cleanup/fix-config
branch
from
42d466c to
5cacbdf
Compare
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
removed
the
lgtm
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
kerthcet
force-pushed
the
cleanup/fix-config
branch
from
573646b to
0777ce2
Compare
Signed-off-by: kerthcet <[email protected]>
|
/lgtm |
InftyAI-Agent
added
the
lgtm
|
cc @carlory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
part of #350
Special notes for your reviewer
Does this PR introduce a user-facing change?