Skip to content

feat: update sglang version to v0.4.5 to fix /health_generate endpoint 404 error #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2025
Merged

feat: update sglang version to v0.4.5 to fix /health_generate endpoint 404 error #383

merged 2 commits into from
Apr 27, 2025

Conversation

cr7258
Copy link
Contributor

@cr7258 cr7258 commented Apr 27, 2025 •
edited
Loading

What this PR does / why we need it

I can't determine which version first introduced health_generate endpoint, but updating to the latest version can solve this problem.

[2025-04-27 06:42:29] INFO:     240.243.170.78:48388 - "GET /health_generate HTTP/1.1" 200 OK
[2025-04-27 06:42:38] INFO:     240.243.170.78:39550 - "GET /health HTTP/1.1" 200 OK
[2025-04-27 06:42:48] INFO:     240.243.170.78:60746 - "GET /health HTTP/1.1" 200 OK
[2025-04-27 06:42:58] INFO:     240.243.170.78:51680 - "GET /health HTTP/1.1" 200 OK
[2025-04-27 06:43:08] INFO:     240.243.170.78:54522 - "GET /health HTTP/1.1" 200 OK

Which issue(s) this PR fixes

Fixes #382

Special notes for your reviewer

Does this PR introduce a user-facing change?

update sglang version to v0.4.5

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 27, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet April 27, 2025 06:44
@pacoxu
Copy link
Contributor

pacoxu commented Apr 27, 2025

/lgtm
/assign @kerthcet

@pacoxu
Copy link
Contributor

pacoxu commented Apr 27, 2025

/kind bug

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Apr 27, 2025
@InftyAI-Agent InftyAI-Agent added bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 27, 2025
@InftyAI-Agent InftyAI-Agent removed the lgtm Looks good to me, indicates that a PR is ready to be merged. label Apr 27, 2025
@kerthcet
Copy link
Member

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2025
@kerthcet
Copy link
Member

/retest

@kerthcet kerthcet mentioned this pull request Apr 27, 2025
Closed
@kerthcet
Copy link
Member

kerthcet commented Apr 27, 2025 •
edited
Loading

We met a ci workflow error here: kerthcet/github-workflow-as-kube#12, LGTM evicted @pacoxu from the assignees.

@kerthcet
Copy link
Member

/triage accepted

@InftyAI-Agent InftyAI-Agent added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a label and requires one. labels Apr 27, 2025
@InftyAI-Agent InftyAI-Agent merged commit a827583 into InftyAI:main Apr 27, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SGLang pod not ready: /health_generate endpoint returns 404
4 participants
@cr7258 @pacoxu @kerthcet @InftyAI-Agent