feat: spread container env to initContianers #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
|
/assign @kerthcet |
kerthcet
reviewed
Mar 10, 2025
| }) | ||
| } | ||
|
|
||
| func spreadEnvToInitContainer(containerEnv []corev1.EnvVar, initContainer *corev1.Container) { |
There was a problem hiding this comment.
Can we add a test to make sure only the envs we set in the Playground or BackendRuntime will be spread to the initContainers?
There was a problem hiding this comment.
Added. PTAL.
/kind feature
nayihz
force-pushed
the
feat_spread_env
branch
2 times, most recently
from
694c2c8 to
771cadd
Compare
|
/kind feature |
InftyAI-Agent
added
feature
|
I think integration test makes more sense here, we set the env in playground and validate the envs in the pod initContainer, but unit tests also looks good to me. /lgtm |
InftyAI-Agent
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #292
Special notes for your reviewer
Does this PR introduce a user-facing change?