Skip to content

Conversation

qinguoyi
Copy link
Member

What this PR does / why we need it

datetime.now() returns a datetime object containing date and time, not simple seconds or milliseconds

Which issue(s) this PR fixes

None

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 24, 2024
@kerthcet
Copy link
Member

/kind bug
/lgtm
/approve

Thanks!

By the way, I'm developing a new project https://github.com/InftyAI/Manta which tries to share model weights across the cluster, which means we may change part of the code in the future. Just FYI.

@InftyAI-Agent InftyAI-Agent added bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 25, 2024
@InftyAI-Agent InftyAI-Agent merged commit ed1556f into InftyAI:main Sep 25, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants