-
-
Notifications
You must be signed in to change notification settings - Fork 43
chore:update leader-elect chart config #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should explain more clear about the advices, what we need is just an example about how to configure the controller args.
Please squash the commit after addressing the comments. Thanks.
/kind documentation |
chore:update leader-elect chart config
tk, as suggested, I re-push the code. but, i still have a question, what is the difference between value.yaml and value.global.yaml, because there are already complete examples to config in value.yaml |
That's a good question, the answer is values.yaml is autogenerated, if you take a look at the Anyway, we need to update the chart README.md to avoid such confusions. |
/lgtm Thanks @qinguoyi for your patience and efforts. |
What this PR does / why we need it
update leader-elect chart config
Which issue(s) this PR fixes
none
Special notes for your reviewer
Does this PR introduce a user-facing change?