Skip to content

Conversation

qinguoyi
Copy link
Member

What this PR does / why we need it

update leader-elect chart config

Which issue(s) this PR fixes

none

Special notes for your reviewer

Does this PR introduce a user-facing change?

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 20, 2024
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should explain more clear about the advices, what we need is just an example about how to configure the controller args.

Please squash the commit after addressing the comments. Thanks.

@kerthcet
Copy link
Member

/kind documentation

@InftyAI-Agent InftyAI-Agent added documentation Categorizes issue or PR as related to documentation. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 20, 2024
chore:update leader-elect chart config
@qinguoyi
Copy link
Member Author

tk, as suggested, I re-push the code.

but, i still have a question, what is the difference between value.yaml and value.global.yaml, because there are already complete examples to config in value.yaml

@kerthcet
Copy link
Member

kerthcet commented Sep 21, 2024

tk, as suggested, I re-push the code.

but, i still have a question, what is the difference between value.yaml and value.global.yaml, because there are already complete examples to config in value.yaml

That's a good question, the answer is values.yaml is autogenerated, if you take a look at the Makefile, we have a helm command, once run make helm, the values.yaml will be generated and overwritten, so we have another global values yaml to store customized configurations.

Anyway, we need to update the chart README.md to avoid such confusions.

@kerthcet
Copy link
Member

/lgtm
/approve

Thanks @qinguoyi for your patience and efforts.

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2024
@InftyAI-Agent InftyAI-Agent merged commit dc73c89 into InftyAI:main Sep 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. documentation Categorizes issue or PR as related to documentation. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants