change playground.elasticConfig.maxReplicas to a required parameter.

[nayihz]

llmaz/pkg/controller/inference/playground_controller.go

Lines 560 to 562 in afe1da1

	if playground.Spec.ElasticConfig.MaxReplicas == nil {
	// The value is hardcoded, because maxReplicas is required by HPA.
	hpa.Spec.MaxReplicas = 99999

Why we hardcode playground.Spec.ElasticConfig.MaxReplicas when user does not set, but not make this field to a required field?

/cc @kerthcet

[kerthcet]

I'm ok to make it a required field, the original idea is scale the replicas to infinity, so maxReplicas should not be set.

[nayihz]

HPA do not support to set maxReplicas to infinity. So I think we should let users to set maxReplicas.

[nayihz]

/remove-kind support
/kind feature

[kerthcet]

HPA do not support to set maxReplicas to infinity. So I think we should let users to set maxReplicas.

Yes, so i set it to a big number at first, anyway let's make it required.

[nayihz]

Close it after #331 merged.
/close