Bugfix/desmakers 4316 spi normal pins 11 12 13 not functioning on xmc4700 relax kit #325
Conversation
…S-4316-spi-normal-pins-11-12-13-not-functioning-on-xmc4700-relax-kit
| enable-deltas-report: false | ||
| sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} | ||
|
|
||
| - name: Modify the environment variable |
There was a problem hiding this comment.
These changes are in a separate PR. #324. Are they needed here as well?
There was a problem hiding this comment.
otherwise compilation tests are not working. will first merge the other one to master
| uint8_t SCK = PIN_SPI_SCK_SD; | ||
| SPIClass SPI(&XMC_SPI_default); | ||
| SPIClass SPI1(&XMC_SPI_for_xmc_SD); | ||
| #else // normal behaviour |
There was a problem hiding this comment.
Is this formatted? with the clang?
The indentation of the preprocessor and not the rest of the code it is quite unclear. The code should be indented together with the preprocessor sections. If not better not to indent the nested pre-processor directives.
There was a problem hiding this comment.
Yes, this is actually after format, otherwise clang-format will report an error.
I can look into clang config. i also think this part is not clear enough
There was a problem hiding this comment.
Yep, we have to configure that properly... But okay, that is not in the scope of this PR, so nothing to be changed for this PR.
…2-13-not-functioning-on-xmc4700-relax-kit
LinjingZhang
deleted the
bugfix/DESMAKERS-4316-spi-normal-pins-11-12-13-not-functioning-on-xmc4700-relax-kit
branch
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Solve the problem that the default spi is overwritten when the XMC4700 relax kit sets the SD card PIN to the default value.
Tested the default SPI pins and the SD card function, both work fine!
Related Issue
https://jirard.intra.infineon.com/browse/DESMAKERS-4316
Context