Skip to content

Conversation

cyn0x8
Copy link
Contributor

@cyn0x8 cyn0x8 commented Feb 20, 2025

implements / closes #3367

@Raltyro
Copy link

Raltyro commented Feb 20, 2025

I think you could change the capitilzation to "frameRate" in favor of FlxAnimation

@Geokureli
Copy link
Member

I think you could change the capitilzation to "frameRate" in favor of FlxAnimation

good to be consistent, but it seems flixel is already inconsistent on this
https://github.com/HaxeFlixel/flixel/blob/dev/flixel/FlxG.hx#L127-L134

https://github.com/search?q=repo%3AHaxeFlixel%2Fflixel%20framerate&type=code
flash/openfl use capital R, I personally like lowercase, when we come to a decision we should rename the existing ones in a different PR

@Raltyro
Copy link

Raltyro commented Feb 20, 2025

fair enough, that works too

@cyn0x8 cyn0x8 marked this pull request as draft February 21, 2025 10:36
@DetectiveBaldi
Copy link
Contributor

Any updates on this? Been working on a project and the need for variable tween frame rate has come up as a must have
Would rather not shadow the current implementation for my project but tweens honestly don't seem very easy to extend

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Sep 16, 2025

Any updates on this? Been working on a project and the need for variable tween frame rate has come up as a must have
Would rather not shadow the current implementation for my project but tweens honestly don't seem very easy to extend

oh to be honest i completelyy forgot this pr existed
ill rebase and try to make progress today

Co-Authored-By: George Kurelic <[email protected]>
@cyn0x8 cyn0x8 marked this pull request as ready for review September 21, 2025 03:26
@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Sep 21, 2025

the number of updates appears to be floor(max(duration * tweenfps, duration * gamefps - 1))

Copy link
Member

@Geokureli Geokureli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, will merge once 6.1.1 is released (hopefully soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlxTween framerate feature
4 participants