-
Notifications
You must be signed in to change notification settings - Fork 10
[TTAHUB-3040] Resolve OWASP warnings #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettEHill
approved these changes
Jul 16, 2024
nvms
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Resolve OWASP generated warnings in the CI around the content security policy by adding new configuration and self-hosting a font we previously linked from Google. Also disallowed the "x-powered-by" header to stop easy sniffing of our platform code.
Note that we are currently unable to resolve one medium issue around the style-src CSP. Plotly still injects CSS in an manner considered unsafe. issue, fix awaiting merge
How to test
Confirm that all the "medium" errors are resolved in the dynamic security scan. except for the 1 that cannot be resolved ("style-src contains unsafe-inline"
Confirm that assets are still loaded as expected and the site still functions, etc. This PR is deployed to sandbox for easier testing.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy