Enable decompose pass in TE graph optimization and add Linear support #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a decompose pass in TE graph optimization to decompose specified Ops
into a series of other Ops providing equivalent functionality. And add aten::Linear support in TE based on the newly added decompose pass as Linear can be constructed with matmul and add by nature.
The decompose pass can help TE to support more Ops like aten::linear which can be constructed with other Ops by nature, and also other scenarios with performance beneficial or ease the lowering/optimization inside TE.
Two tricky parts inside the decompose process:
This PR has been tested with unit test and also on wide&deep model which can successfully make aten::linear been pulled into NNC fusion group and provided better performance.