Enable NNC AdaptiveAvgPool2d for ChannelsLast and quantization #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated AdaptiveAvgPool2D lowering/externcall to support quantization and ChannelsLast * Implemented out version of AdaptiveAvgPool2d externalcall to improve memory efficiency when applicable * Added new test case to cover quantization/ChannelsLast scenaro of this OP and also udpated UnaryFloat case which uses this OP
Guobing-Chen
force-pushed
the
nnc_quant_op_adaptiveavgpool2d
branch
from
1486190 to
fc32739
Compare
jgong5
reviewed
Jul 19, 2022
jgong5
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After previous PR of basic NNC quantization support, there should be a serial of follow-up PRs to fix/implement OP-level quantization and ChannelsLast support. Scopes including existing NNC quantization OPs, non-quant-specific NNC OPs (e.x.: various pooling OPs).
As one of this serial, this PR targets to fix/implement quantization/ChannelsLast support for AdaptiveAvgPool2D. Details as below: