Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Oct 9, 2017

No description provided.

@nkubala nkubala requested review from aaron-prindle and r2d4 October 9, 2017 17:59
aaron-prindle
aaron-prindle previously approved these changes Oct 9, 2017
Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it might be better to move the using a CHANGELOG.md file for this and future releases:
https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md

it will also make automatic releases easier as the Github releases won't need anything done manually.

r2d4
r2d4 previously approved these changes Oct 9, 2017
@r2d4
Copy link
Contributor

r2d4 commented Oct 9, 2017

+1 on the changlelog comment

@nkubala nkubala dismissed stale reviews from r2d4 and aaron-prindle via cea8709 October 9, 2017 22:02
@nkubala
Copy link
Contributor Author

nkubala commented Oct 9, 2017

good call, added changelog with previous release notes.

@nkubala nkubala merged commit 8ae444a into GoogleContainerTools:master Oct 9, 2017
@nkubala nkubala deleted the release branch October 9, 2017 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants