Skip to content

Add wasm test cases #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: v7
Choose a base branch
from
Open

Add wasm test cases #3330

wants to merge 4 commits into from

Conversation

ArhanChaudhary
Copy link
Contributor

Addresses this comment

cc @tropicadri

@ArhanChaudhary
Copy link
Contributor Author

BTW, I'm not sure why the workbox-cli test cases are failing, but they're working locally for me

@tropicadri
Copy link
Contributor

Thanks I'll take a look at the tests, see if I can make them pass.

@ArhanChaudhary
Copy link
Contributor Author

@tropicadri See this comment thread, I think this should otherwise be ready for approval

@ArhanChaudhary
Copy link
Contributor Author

bump :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArhanChaudhary @tropicadri