Fix Search now ignores accents diacritics 209 #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 28, 2025 01:04
|
@naveensingh need an idea to improve line length... |
naveensingh
requested changes
Sep 28, 2025
app/src/main/kotlin/org/fossify/musicplayer/extensions/Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/MyViewPagerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/extensions/Activity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/extensions/Activity.kt
Outdated
Show resolved
Hide resolved
naveensingh
added
the
waiting for author
Co-authored-by: Naveen Singh <[email protected]>
naveensingh
requested changes
Sep 28, 2025
app/src/main/kotlin/org/fossify/musicplayer/fragments/MyViewPagerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/TracksFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/AlbumsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/activities/TracksActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/FoldersFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/GenresFragment.kt
Outdated
Show resolved
Hide resolved
removed unused import hopefully fix for MaxLineLength
naveensingh
requested changes
Sep 28, 2025
There was a problem hiding this comment.
- It still doesn't work in
QueueActivity. - More formatting errors below.
https://github.com/FossifyOrg/General-Discussion#contributing-code
app/src/main/kotlin/org/fossify/musicplayer/fragments/AlbumsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/ArtistsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/FoldersFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/GenresFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/PlaylistsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/activities/TracksActivity.kt
Show resolved
Hide resolved
added 2 commits
September 28, 2025 12:17
remove normalizing in MainActivity since we are normalizing in fragments fix incorrect (not needed) lambda parameter in several fragment
fix normalized tracks
naveensingh
requested changes
Sep 28, 2025
app/src/main/kotlin/org/fossify/musicplayer/activities/QueueActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/fossify/musicplayer/fragments/AlbumsFragment.kt
Outdated
Show resolved
Hide resolved
naveensingh
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).