Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Settings: merge stepsToPerform and useBlockStepping into UI refresh rate option

Summary

Implements issue #410 by combining the separate "Number of batched steps" and "Block Stepping" settings into a single "UI refresh rate" dropdown option. The new setting provides two modes:

  • "After N instructions": Allows configuring a custom number of instructions (with number input)
  • "After block": Steps block-by-block (equivalent to the old block stepping behavior)

Key Changes:

  • Added new UiRefreshRate type and Redux state structure
  • Replaced two separate UI controls with a combined dropdown + conditional number input
  • Updated getStepsToPerform() logic to use the new state structure
  • Maintained backward compatibility by syncing old state fields when new setting changes

Review & Testing Checklist for Human

🔴 HIGH PRIORITY - I encountered testing limitations that require human verification:

  • Test settings dialog functionality: Open the debugger settings dialog and verify the new "UI refresh rate" control appears and functions correctly (I was unable to open the settings dialog during testing)
  • Test stepping behavior: Verify that both "After N instructions" and "After block" modes work correctly when running/stepping through programs
  • Test UI interactions: Ensure the number input appears/disappears correctly when switching between dropdown options, and accepts valid numeric input (1-1000)
  • Test backward compatibility: Check that existing debugger state doesn't break - try loading programs that previously used different combinations of the old settings
  • Test edge cases: Invalid input values, switching between modes while debugging, etc.

Notes

⚠️ Testing Limitation: I was unable to fully test the UI functionality locally due to the settings dialog not opening properly in my browser session. The code changes follow the established patterns in the codebase, but the UI integration needs human verification.

The implementation maintains the existing logic flow - getStepsToPerform() now reads from uiRefreshRate instead of the separate fields, and the new setUiRefreshRate action keeps the old state fields in sync for any remaining dependencies.


Requested by: @tomusdrw
Devin session: https://app.devin.ai/sessions/967237ffe34443caa7e18a1d87574ddf

…setting

- Add new UiRefreshRate type and Redux state
- Replace separate settings with combined dropdown + input
- Maintain backward compatibility with existing logic
- Update getStepsToPerform to use new state structure

Fixes #410

Co-Authored-By: Tomek Drwięga <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

netlify bot commented Sep 18, 2025

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit 586a4aa
🔍 Latest deploy log https://app.netlify.com/projects/pvm-debugger/deploys/68cc09266793eb0008a56509
😎 Deploy Preview https://deploy-preview-411--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tomusdrw tomusdrw merged commit 930577f into main Sep 22, 2025
6 checks passed
@tomusdrw tomusdrw deleted the devin/1758201868-ui-refresh-rate-setting branch September 22, 2025 08:38
@tomusdrw tomusdrw mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant