Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Aug 20, 2025

Memory: start initial view at 0x1000 (#370)

Summary

Changed the default initial memory view to start at address 0x1000 (4096 decimal) instead of 0x0, as requested in issue #370. This addresses the requirement that "Since the initial 16 pages are reserved anyway, we should display the memory starting at 0x1000."

Files changed:

  • src/store/workers/workersSlice.ts - Updated worker memory initialization to use startAddress: 0x1000 and adjusted stopAddress accordingly

Review & Testing Checklist for Human

  • Visual verification: Load the app and confirm the Memory > Infinite tab shows addresses starting at 0x1000 instead of 0x0
  • Multiple loading methods: Test that memory starts at 0x1000 when loading programs via examples, file upload, and URL parameters
  • Address validation: Confirm 0x1000 is the correct starting address (issue mentions "16 pages reserved" - verify this means start at 1 page, not 16 pages = 0x10000)
  • Existing functionality: Verify memory navigation, jumping to addresses, and infinite scrolling still work correctly

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    Issue["#370: Memory should show 0x1000 initially"]
    WorkersSlice["src/store/workers/<br/>workersSlice.ts"]
    MemoryInfinite["src/components/MemoryPreview/<br/>MemoryInfinite.tsx"]
    InitWorkers["initAllWorkers()"]
    MemoryView["Memory View UI"]

    Issue -->|"requirement"| WorkersSlice
    WorkersSlice -->|"creates workers with<br/>startAddress: 0x1000"| InitWorkers
    InitWorkers -->|"loads initial memory<br/>chunk from startAddress"| MemoryInfinite
    MemoryInfinite -->|"displays memory<br/>starting at 0x1000"| MemoryView

    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit  
        L3["Context/No Edit"]:::context
    end

    class WorkersSlice major-edit
    class MemoryInfinite,InitWorkers,MemoryView context

    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB  
    classDef context fill:#FFFFFF
Loading

Notes

The change is minimal and focused, affecting only the default memory initialization. However, visual testing is essential to confirm the memory view actually displays the expected address range in the UI.

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit a50cbc1
🔍 Latest deploy log https://app.netlify.com/projects/pvm-debugger/deploys/68a5a0e03cdda8000850d2ef
😎 Deploy Preview https://deploy-preview-381--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tomusdrw tomusdrw enabled auto-merge (squash) August 20, 2025 09:34
@tomusdrw tomusdrw merged commit 3bdd92d into main Aug 20, 2025
6 checks passed
@tomusdrw tomusdrw deleted the devin/1755681756-memory-initial-0x1000 branch August 20, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant