Load SPI program from hex string #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith loading raw bytes
✅ Deploy Preview for pvm-debugger ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomusdrw
approved these changes
Feb 23, 2025
| initial: { ...initialState, regs, mem: memory }, | ||
| name: "custom", | ||
| }; | ||
| } catch { |
There was a problem hiding this comment.
Can we make try a bit more minimal? I guess the only thing that is expected to throw is Program.fromSpi, isn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need possibility to load SPI program from hex string so I added it. Additionally I spotted two problems:
Both problems are fixed:
Screen.Recording.2025-02-23.at.16.23.56.mov
and it is possible to load SPI program from hex string:
Screen.Recording.2025-02-23.at.16.25.17.mov