[Hold for payment 2025-02-17][$250] Expense - Not here page shows up briefly when deleting the expense while it is highlighted

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.85-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+140105kh@applause.expensifail.com
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create three manual expenses.
4. Go to transaction thread of any expense.
5. Click on the header subtitle to return to expense report.
6. Right click on the previously visited expense report which is now highlighted.
7. Click Delete expense.
8. Delete the expense.

Expected Result:

Not here page will not show up briefly when deleting the expense while it is highlighted.

Actual Result:

Not here page shows up briefly when deleting the expense while it is highlighted.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881828763619055376
• Upwork Job ID: 1881828763619055376
• Last Price Increase: 2025-01-28
• Automatic offers:
• brunovjk | Reviewer | 105898628

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @Maurishus! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[github-actions]

⚠️ @Maurishus Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[M00rish]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Not here page shows up briefly when deleting the expense while it is highlighted

What is the root cause of that problem?

when the expense is highlighted it's ID is taken from the url :

App/src/pages/home/ReportScreen.tsx

Line 103 in 7b9e55e

const reportActionIDFromRoute = route?.params?.reportActionID ?? '';

and handed to usePaginatedReportActions to get the linkedAction:

App/src/pages/home/ReportScreen.tsx

Line 242 in 7b9e55e

const {reportActions, linkedAction, sortedAllReportActions, hasNewerActions, hasOlderActions} = usePaginatedReportActions(reportID, reportActionIDFromRoute);

once the delete happens, and because the param is not removed immediately from the navigation, it's taken again and handed to usePaginatedReportActions,

so isLinkedActionDeleted is true and prevIsLinkedActionDeleted is true also because previous action which is same action is deleted, that makes isLinkedActionBecomesDeleted false :

App/src/pages/home/ReportScreen.tsx

Line 388 in 7b9e55e

const isLinkedActionBecomesDeleted = prevIsLinkedActionDeleted !== undefined && !prevIsLinkedActionDeleted && isLinkedActionDeleted;

and so shouldShowNotFoundLinkedAction is true

App/src/pages/home/ReportScreen.tsx

Lines 391 to 392 in 7b9e55e

	const shouldShowNotFoundLinkedAction =
	(!isLinkedActionInaccessibleWhisper && isLinkedActionDeleted && !isLinkedActionBecomesDeleted) ||

and then param is cleared with this useEffect

What changes do you think we should make in order to solve the problem?

if action has been deleted we can keep a ref of it's ID, so don't we provide it again to usePaginatedReportActions

LastDeletedActionIDRef = useReff(null);
const reportActionIDFromRoute = LastDeletedActionIDRef.current !== route?.params?.reportActionID ? route?.params?.reportActionID : '';

    useEffect(() => {
        if(!isLinkedActionDeleted){
            return;
        }
        
        LastDeletedActionIDRef.current = isLinkedActionDeleted ? linkedAction?.reportActionID ?? '' : '';
    }, [isLinkedActionDeleted]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

if Highlighted getback to main thread before delete.

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Line 270 in 7b9e55e

const confirmDeleteAndHideModal = useCallback(() => {

....
const confirmDeleteAndHideModal = useCallback(() => {
        const isHighlighted = navigationRef.current.getCurrentRoute().params.reportActionID === 
             reportActionRef.current?.reportActionID;
        if (isHighlighted) {
            Navigation.setParams({reportActionID: ''});
        }

        callbackWhenDeleteModalHide.current = runAndResetCallback(onConfirmDeleteModal.current);
        const reportAction = reportActionRef.current;
        if (ReportActionsUtils.isMoneyRequestAction(reportAction)) {
            const originalMessage = ReportActionsUtils.getOriginalMessage(reportAction);
          .......

[github-actions]

⚠️ @M00rish Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page shows up briefly when deleting the expense while it is highlighted.

What is the root cause of that problem?

Here're the logics to show not found page

App/src/pages/home/ReportScreen.tsx

Lines 404 to 407 in 7b9e55e

	const shouldShowNotFoundPage = useMemo((): boolean => {
	if (shouldShowNotFoundLinkedAction) {
	return true;
	}

And

App/src/pages/home/ReportScreen.tsx

Lines 391 to 392 in 7b9e55e

	const shouldShowNotFoundLinkedAction =
	(!isLinkedActionInaccessibleWhisper && isLinkedActionDeleted && !isLinkedActionBecomesDeleted) ||

When users delete the linked action, isLinkedActionDeleted will be true, that cause isLinkedActionBecomesDeleted is true as well (prevIsLinkedActionDeleted is false). But after the next render, prevIsLinkedActionDeleted will be true that causes isLinkedActionBecomesDeleted becomes false

So shouldShowNotFoundLinkedAction is true, that why we can see the not found page

And when isLinkedActionBecomesDeleted is true

App/src/pages/home/ReportScreen.tsx

Line 707 in 7b9e55e

Navigation.setParams({reportActionID: ''});

we update the linkedReportActionID to empty string, so isLinkedActionDeleted will be false (there's no linked action)

That why the not found page is shown shortly

What changes do you think we should make in order to solve the problem?

We should detect the linked action is removing, so don't open the not found page

    const isResetingLinkedAction = useRef(false);
...

const shouldShowNotFoundLinkedAction =
        (!isLinkedActionInaccessibleWhisper && isLinkedActionDeleted && !isLinkedActionBecomesDeleted && !isResetingLinkedAction.current) ||
...

    useEffect(() => {
        // If the linked action is previously available but now deleted,
        // remove the reportActionID from the params to not link to the deleted action.
        if (!isLinkedActionBecomesDeleted) {
            return;
        }
        isResetingLinkedAction.current = true;
        Navigation.setParams({reportActionID: ''});
    }, [isLinkedActionBecomesDeleted]);

    useEffect(() => {
        if(linkedAction || !isResetingLinkedAction.current){
            return;
        }
        isResetingLinkedAction.current = false
    },[linkedAction])

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is the UI issue so no need for unit test.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021881828763619055376