fix: Handle emojis in response keys better

[scottlovegrove]

Fixes #307

Basically what was happening was the key for the reactions (ie, the emoji) was being passed from axios, to axios-case-converter then finally to camel-case, which was the stripping out emojis as they are not supported.

So, now we check to see whether the input is a single/composite emoji, if it is, we can assume this is a reaction and nothing else and not pass it through camel case.

The reason this wasn't caught by the tests, and why I have not added a test for this, is because all the tests are mocking out Axios completely, meaning the processing where this bug was happening doesn't actually happen. I'm not sure how to alleviate that. I have, at least, added some tests for the new customCamelCase function.

In order to test, create your scratch.ts file (see readme on how to run it), and put this in it:

import { TodoistApi } from './TodoistApi'

const token = 'YOUR_TOKEN'

const api = new TodoistApi(token)

async function doIt() {
    try {
        const comments = await api.getComments({ taskId: 'YOUR_TASK_ID' })
        console.log({ reactions: JSON.stringify(comments.results[0].reactions) })
    } catch (error: unknown) {
        if (error instanceof Error) {
            console.log(error)
        }
    }
}

doIt().catch(() => {
    // noop
})

Replace with your token, and a task id for a task that has a comment where that comment has a reaction.

[henningmu]

Looks good. Perhaps we could consider a non-mocked axios for this test in restClient.test.ts. However, I don't think this is absolutely necessary 👍

[scottlovegrove]

Perhaps we could consider a non-mocked axios for this test in restClient.test.ts

Thinking about it, perhaps we could add msw in this instance 🤔 That would allow us to have the mock data without mocking Axios. But as you say, probably not necessary.