fix: Change EntityInHierarchy.parentId to string #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on https://github.com/Doist/integrations-backlog/issues/418 (upgrade
Todoist-Outlook
to API v2), I've noticed that some of the errors and test failures looks something like:Since the API v2 now treats all
id
s as strings (i.e.projectId
s,sectionId
s,taskId
s, etc.), it makes sense to change thisEntityInHierarchy.parentId
to string as well.This is apparently only used in
Todoist-Outlook
(https://github.com/search?l=TypeScript&q=org%3ADoist+EntityInHierarchy&type=Code) so this seems like a safe change.