Skip to content

fix: Use camelCased properties instead of snake_case #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022
Merged

fix: Use camelCased properties instead of snake_case #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dd0923
fix: Use camelCased properties instead of snake_case
henningmu Sep 22, 2022
30a4768
chore: Fix unrelated CI complaint
henningmu Sep 22, 2022
40a179d
chore: Bump version to 2.0.4
henningmu Sep 26, 2022
bdbfed5
chore: Apply suggestions from code review
henningmu Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@doist/todoist-api-typescript",
"version": "2.0.3",
"version": "2.0.4",
"description": "A typescript wrapper for the Todoist REST API.",
"author": "Doist developers",
"repository": "[email protected]:doist/todoist-api-typescript.git",
Expand Down
6 changes: 3 additions & 3 deletions src/testUtils/testDefaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ export const DEFAULT_QUICK_ADD_RESPONSE: QuickAddTaskResponse = {
labels: DEFAULT_LABELS,
responsibleUid: DEFAULT_ASSIGNEE,
checked: 0,
added_at: DEFAULT_DATE,
added_by_uid: DEFAULT_CREATOR,
addedAt: DEFAULT_DATE,
addedByUid: DEFAULT_CREATOR,
due: {
date: DEFAULT_DATE,
timezone: null,
Expand Down Expand Up @@ -117,7 +117,7 @@ export const DEFAULT_PROJECT: Project = {
isInboxProject: false,
isTeamInbox: false,
viewStyle: DEFAULT_PROJECT_VIEW_STYLE,
url: `https://todoist.com/showProject?id=123`,
url: 'https://todoist.com/showProject?id=123',
}

export const INVALID_PROJECT = {
Expand Down
4 changes: 2 additions & 2 deletions src/types/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ export type QuickAddTaskResponse = {
labels: string[]
responsibleUid: string | null
checked: number // completed
added_at: string // created
added_by_uid: string | null
addedAt: string // created
addedByUid: string | null
due: {
date: string
timezone: string | null
Expand Down
4 changes: 2 additions & 2 deletions src/utils/taskConverters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ export function getTaskFromQuickAddResponse(responseData: QuickAddTaskResponse):
labels: responseData.labels,
priority: responseData.priority,
commentCount: 0, // Will always be 0 for a quick add
createdAt: responseData.added_at,
createdAt: responseData.addedAt,
url: getTaskUrlFromQuickAddResponse(responseData),
creatorId: responseData.added_by_uid ? responseData.added_by_uid : '',
creatorId: responseData.addedByUid ?? '',
...(due !== undefined && { due }),
...(responseData.parentId !== null && { parentId: responseData.parentId }),
...(responseData.responsibleUid !== null && {
Expand Down