refactor: Accept nulls for optional entity fields #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #133
Fields that weren't being returned in v1 of the REST API may now be returned but have a value of
null
. Our validation wasn't catering for that. Have updated the partial types to accept the type or NULL.There were a few other instances of number-based ID usage that hadn't been switched. These have now been corrected.
Testing
You can try and follow the instructions in the readme using the
scratch.ts
file in order to test this.I found putting breakpoints on the console.logs allowed me to see the problem. Prior to the fix, the ones in the catch would get hit, post-fix, the one inside the try would get hit.
I have updated all the tests to account for all of the partial/nulls though.