Skip to content

Conversation

scottlovegrove
Copy link
Contributor

No description provided.

@scottlovegrove scottlovegrove force-pushed the scottl/rest-v2 branch 2 times, most recently from 45cf129 to f64fbd0 Compare August 24, 2022 13:30
Copy link
Collaborator

@lefcha lefcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, apart from some comments.

@scottlovegrove
Copy link
Contributor Author

Great spot that I was still using v8 sync types @lefcha, have updated this now to use v9 and its types.

@scottlovegrove scottlovegrove marked this pull request as ready for review September 5, 2022 10:26
@scottlovegrove scottlovegrove requested review from a team and engfragui and removed request for a team September 5, 2022 10:26
@lefcha
Copy link
Collaborator

lefcha commented Sep 5, 2022

Looks good now @scottlovegrove

@scottlovegrove scottlovegrove merged commit c9ea2af into main Sep 8, 2022
@scottlovegrove scottlovegrove deleted the scottl/rest-v2 branch September 8, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants