Align links to slots in subgraphs #5876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Nodes mode\n\n- In subgraph link rendering, use getSlotPosition() for the regular node side when Vue Nodes are enabled.\n- Keeps IO anchors on subgraph IO nodes; regular node endpoints now match DOM-tracked slot centers.\n- Mirrors root-graph behavior; preserves fallback to legacy math when Vue Nodes are disabled.
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 10/01/2025, 04:43:00 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
benceruleanlu
changed the title
christian-byrne
approved these changes
Oct 1, 2025
benceruleanlu
deleted the
fix/subgraph-vue-slot-anchors-20250930-212843
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vue nodes is enabled, switch to the new getSlotPosition for subgraph nodes as well.
This aligns links to slots in subgraphs.
Do note, getSlotPosition is actually the new standard, but we fallback to inputNode.getInputPos since it's so core, idea is to switch over fully to getSlotPosition without the vue flag once things are more stable.
┆Issue is synchronized with this Notion page by Unito