[ci] Update browser tests for new Templates modal #5802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 09/26/2025, 08:05:37 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
added
area:testing
New Browser Test Expectations
|
Changes:
|
dosubot
bot
added
size:M
christian-byrne
changed the title
Myestery
approved these changes
Sep 26, 2025
| // Open templates dialog | ||
| await comfyPage.executeCommand('Comfy.BrowseTemplates') | ||
| await expect(comfyPage.templates.content).toBeVisible() | ||
|
|
There was a problem hiding this comment.
These tests will make sense more on the base modal
There was a problem hiding this comment.
The test case was originally about ensuring the grid was visible. The bug from a long time ago was the nav bar fully covering the grid. I think checking the template base modal visibility is covered in other test cases, so it should error rather than fail expectation in this case if not visible.
christian-byrne
deleted the
regenerate-playwright-screenshots-20250926-115310
branch
christian-byrne
added a commit
that referenced
this pull request
Sep 27, 2025
Fixes flaky templates modal test introduced in #5802 by ensuring the templates modal is visible before querying the visible card count and asserting that it is greater than 0. If we immediately count the number of cards after executing the "load templates" command, it's possible that there are 0 visible due to them loading (rather than being caused by a legitimate bug). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5808-fix-flaky-templates-browser-test-27b6d73d365081e58c65f608944976a0) by [Unito](https://www.unito.io)
christian-byrne
added a commit
that referenced
this pull request
Sep 27, 2025
## Summary - Regenerate 3 Playwright screenshot baselines to reflect UI changes from #5142 - Also fixed [this case](https://f01efc75.comfyui-playwright-chromium.pages.dev/#?testId=35f0453d615a452757ca-379124415c5b7e9060d2) (test case for responsive sizing) as it was using outdated logic. New logic: ensures that the nav is collapsed on mobile but visible on tablet and desktop screen sizes. It also ensures that, at all the main breakpoints, at least 1 card is visible (covers bug that the case was originally written for wherein the nav was fully covering the cards at narrow screen widths). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5802-ci-Regenerate-Playwright-screenshot-baselines-27a6d73d365081768211da0d24bad2c3) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
christian-byrne
added a commit
that referenced
this pull request
Sep 27, 2025
Fixes flaky templates modal test introduced in #5802 by ensuring the templates modal is visible before querying the visible card count and asserting that it is greater than 0. If we immediately count the number of cards after executing the "load templates" command, it's possible that there are 0 visible due to them loading (rather than being caused by a legitimate bug). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5808-fix-flaky-templates-browser-test-27b6d73d365081e58c65f608944976a0) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
┆Issue is synchronized with this Notion page by Unito