Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 26, 2025

Summary

Fixed WidgetSelect component styling to match other Vue node widgets by using shared base styles.

Changes

  • What: Replaced hardcoded color classes with WidgetInputBaseClass for consistent styling across Vue node widgets

Review Focus

Visual consistency with other input widgets in Vue nodes interface and proper styling inheritance.

Screenshots (if applicable)

Before:

Screenshot from 2025-09-25 18-12-16

After:

Screenshot from 2025-09-25 18-12-07

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 26, 2025
Copy link

github-actions bot commented Sep 26, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 09/27/2025, 02:33:35 AM UTC

📈 Summary

  • Total Tests: 460
  • Passed: 426 ✅
  • Failed: 2 ❌
  • Flaky: 3 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 419 / ❌ 2 / ⚠️ 3 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

arjansingh
arjansingh previously approved these changes Sep 26, 2025
DrJKL
DrJKL previously approved these changes Sep 26, 2025
@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 26, 2025
@github-actions github-actions bot dismissed stale reviews from DrJKL and arjansingh via 825191b September 26, 2025 02:47
@christian-byrne christian-byrne force-pushed the vue-nodes/fix/select-color branch from 825191b to c2a868f Compare September 26, 2025 23:44
@christian-byrne christian-byrne force-pushed the vue-nodes/fix/select-color branch from c2a868f to 0745960 Compare September 27, 2025 02:20
@christian-byrne christian-byrne added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Sep 27, 2025
@christian-byrne
Copy link
Contributor Author

Two expected test failures from the Select component changing colors realteive to snapshot baselines.

@christian-byrne christian-byrne merged commit 4b9d448 into main Sep 27, 2025
2 checks passed
@christian-byrne christian-byrne deleted the vue-nodes/fix/select-color branch September 27, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:vue-migration New Browser Test Expectations New browser test screenshot should be set by github action size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants