Add node pinning functionality to Vue nodes #5772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results⏰ Completed at: 09/27/2025, 05:55:16 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
AustinMroz
previously approved these changes
Sep 25, 2025
webfiltered
previously approved these changes
Sep 25, 2025
| // Delete the flag if unpinned, so that we don't get unnecessary | ||
| // flags.pinned = false in serialized object. | ||
| if (!this.pinned) delete this.flags.pinned | ||
| if (!this.pinned) this.flags.pinned = undefined |
There was a problem hiding this comment.
Supremely happy that this is no longer necessary~
DrJKL
previously approved these changes
Sep 25, 2025
DrJKL
reviewed
Sep 25, 2025
| @edit="handleTitleEdit" | ||
| @cancel="handleTitleCancel" | ||
| /> | ||
| <i-lucide:pin |
There was a problem hiding this comment.
This could use the class based icon, right?
There was a problem hiding this comment.
Is it better? Or just for consistency?
omg I forgot to actually implement the pinning aspect |
christian-byrne
dismissed stale reviews from DrJKL, webfiltered, and AustinMroz
via
d5bb202
christian-byrne
requested review from
Yorha4D,
KarryCharon,
shinshin86,
a team,
viva-jinyi,
ltdrdata,
Myestery,
comfyui-wiki and
pythongosssss
as code owners
dosubot
bot
added
size:XXL
christian-byrne
force-pushed
the
vue-nodes/pinned-state
branch
from
042d45e to
ce0675c
Compare
dosubot
bot
added
size:L
|
Changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added pinning functionality to Vue nodes with hotkey support and visual indicators.
Changes
LGraphNode.vueandNodeHeader.vuewith pin state trackinguseGraphNodeManagerto sync pinned flag with Vue componentsReview Focus
Pin state persistence in graph serialization and visual indicator positioning in node header layout. Verify hotkey doesn't conflict with existing shortcuts.
Technical Details
flags.pinnedproperty inLGraphNodeScreenshots (if applicable)
Related
┆Issue is synchronized with this Notion page by Unito