Skip to content

Conversation

simula-r
Copy link
Contributor

@simula-r simula-r commented Sep 25, 2025

Summary

Improve markdown node by making the textarea match the rendered output width and height.

Fixes: https://www.notion.so/comfy-org/edit-markdown-changes-node-size-2786d73d36508093a417c72b044ba07d?source=copy_link

Screenshots (if applicable)

markdown-node-resize.mp4

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 25, 2025
Copy link

github-actions bot commented Sep 25, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/25/2025, 08:18:21 PM UTC

📈 Summary

  • Total Tests: 461
  • Passed: 431 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 424 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simula-r simula-r merged commit 703de3e into main Sep 25, 2025
25 checks passed
@simula-r simula-r deleted the fix/vue-nodes-markdown branch September 25, 2025 20:21
christian-byrne pushed a commit that referenced this pull request Sep 27, 2025
## Summary

Improve markdown node by making the textarea match the rendered output
width and height.

## Screenshots (if applicable)


https://github.com/user-attachments/assets/4701f947-0a4f-40f3-83c0-94e53cd10106


┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5771-Fix-vue-nodes-markdown-2796d73d365081129428fe9c38178cc4)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants