Skip to content

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 24, 2025

Summary

Replace the unknown type with the interface in Litegraph.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 24, 2025
@DrJKL DrJKL requested a review from arjansingh September 24, 2025 21:06
Copy link

github-actions bot commented Sep 24, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/24/2025, 09:17:13 PM UTC

📈 Summary

  • Total Tests: 459
  • Passed: 428 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 421 / ❌ 0 / ⚠️ 2 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link
Contributor

@arjansingh arjansingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great simplifying types in #5357

@arjansingh arjansingh merged commit 0fea54c into main Sep 24, 2025
25 checks passed
@arjansingh arjansingh deleted the drjkl/typing/slots branch September 24, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants