Skip to content

Conversation

snomiao
Copy link
Member

@snomiao snomiao commented Sep 24, 2025

Summary

This PR fixes a flaky test in the load audio widget spec that was causing intermittent failures in CI.

Problem

The test was attempting to trigger a file chooser event before the widget's upload button was fully rendered and ready for interaction, leading to race conditions.

Solution

Added an explicit wait for the widget element to be visible before triggering the file chooser, ensuring the DOM is ready for interaction.

Changes

  • Added waitFor to verify widget visibility before file upload
  • Ensures proper synchronization between DOM updates and test actions

Test plan

  • Browser tests pass locally
  • Typecheck passes
  • CI tests pass

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

snomiao and others added 2 commits September 24, 2025 15:59
Add explicit wait after loading workflow to ensure audio widget fully
renders before taking screenshot. Follows same pattern as other widget
tests (slider, number) that require rendering time.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Add explicit wait for widget visibility before triggering file chooser
- Ensures the upload button is rendered and ready for interaction
- Fixes intermittent test failures in CI

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

github-actions bot commented Sep 24, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/24/2025, 06:35:50 PM UTC

📈 Summary

  • Total Tests: 460
  • Passed: 430 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 423 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@snomiao snomiao marked this pull request as ready for review September 24, 2025 18:48
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2025
@christian-byrne christian-byrne merged commit 8d12611 into main Sep 24, 2025
25 checks passed
@christian-byrne christian-byrne deleted the sno-fix-flaky-load-audio branch September 24, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants