Skip to content

fix: flaky test 'Can choose existing user' in userSelectView.spec.ts #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Draft

fix: flaky test 'Can choose existing user' in userSelectView.spec.ts #5753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533fd1c
fix: flaky test 'Can choose existing user' in userSelectView.spec.ts
snomiao Sep 24, 2025
36126a5
[auto-fix] Apply ESLint and Prettier fixes
actions-user Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions browser_tests/tests/userSelectView.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,27 @@ test.describe('User Select View', () => {
test('Can choose existing user', async ({ userSelectPage, page }) => {
await page.goto(userSelectPage.url)
await expect(page).toHaveURL(userSelectPage.selectionUrl)

await userSelectPage.existingUserSelect.click()
await page.locator('.p-select-list .p-select-option').first().click()

const dropdownList = page.locator('.p-select-list')
await expect(dropdownList).toBeVisible()

// Wait for dropdown to populate
await page.waitForTimeout(500)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use waitForState({ visible: true }) on the options instead of a timeout.


// Try to click first option if it exists
const firstOption = page.locator('.p-select-list .p-select-option').first()

if ((await firstOption.count()) > 0) {
await firstOption.click()
} else {
// No options available - close dropdown and use new user input
await page.keyboard.press('Escape')
await userSelectPage.newUserInput.fill(`test-user-${Date.now()}`)
}

await userSelectPage.nextButton.click()
await expect(page).toHaveURL(userSelectPage.url)
await expect(page).toHaveURL(userSelectPage.url, { timeout: 15000 })
})
})