-
Notifications
You must be signed in to change notification settings - Fork 376
test(e2e): align test default menu to Top; make legacy specs explicit #5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fa205f7
9902eca
39165dc
b29adf8
5918290
07ec9ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1643,7 +1643,7 @@ export const comfyPageFixture = base.extend<{ | |
|
||
try { | ||
await comfyPage.setupSettings({ | ||
'Comfy.UseNewMenu': 'Disabled', | ||
'Comfy.UseNewMenu': 'Top', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question (non-blocking): would it work to just remove this line altogether since this is the default value? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I think so, good point, will make this change after merge since we have the setting to dismiss approvals after commits |
||
// Hide canvas menu/info/selection toolbox by default. | ||
'Comfy.Graph.CanvasInfo': false, | ||
'Comfy.Graph.CanvasMenu': false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): should we just change this to say like "Some tests require the old menu system"? Or maybe not because that should never be necessary anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be clear enough, since it would say that explicitly by setting it to Disabled, so I don't think this would be needed