Skip to content

fix: Status indicator and close button appearing together #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: Status indicator and close button appearing together #5738

merged 2 commits into from
Sep 23, 2025

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 23, 2025 •
edited by sync-by-unito bot
Loading

Summary

Small fix for the close/status visibility overlap

image

20250923-2140-26 4569642

┆Issue is synchronized with this Notion page by Unito

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 09/23/2025, 09:52:13 PM UTC

📈 Summary

  • Total Tests: 457
  • Passed: 424 ✅
  • Failed: 3 ❌
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 417 / ❌ 3 / ⚠️ 1 / ⏭️ 29
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 23, 2025
webfiltered
webfiltered previously approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it only has one style block.. very disappointing.

AustinMroz
AustinMroz reviewed Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 23, 2025
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.27 labels Sep 23, 2025
@christian-byrne christian-byrne merged commit f7f3240 into main Sep 23, 2025
4 checks passed
@christian-byrne christian-byrne deleted the drjkl/feat/note-node-5 branch September 23, 2025 22:23
@github-actions GitHub Actions
Copy link

@DrJKL Backport to core/1.27 failed: Merge conflicts detected.

Please manually cherry-pick commit f7f32401001b8fc368816601779790a03503b5fa to the core/1.27 branch.

Conflicting files
  • browser_tests/tests/vueNodes/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.png

AustinMroz pushed a commit that referenced this pull request Sep 23, 2025
@DrJKL @AustinMroz
[backport 1.27] fix: Status indicator and close button appearing toge…
6cd682a 
…ther (#5738)

Small fix for the close/status visibility overlap

<img width="392" height="128" alt="image"
src="https://github.com/user-attachments/assets/af25f1d7-a8c3-4155-9123-9fa10724e8db"
/>

![20250923-2140-26
4569642](https://github.com/user-attachments/assets/e1b00a3f-d6e9-416b-9014-df0f9241082e)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5738-fix-Status-indicator-and-close-button-appearing-together-2776d73d3650813e9601e519c8a85043)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <[email protected]>
@AustinMroz AustinMroz mentioned this pull request Sep 23, 2025
Merged
christian-byrne pushed a commit that referenced this pull request Sep 23, 2025
@AustinMroz @DrJKL
[backport 1.27] fix: Status indicator and close button appearing toge…
26d777d 
…ther (#5738) (#5741)

Backport of #5738 to `core/1.27`

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5741-backport-1-27-fix-Status-indicator-and-close-button-appearing-together-5738-2776d73d36508181a7fec09edd816ec5)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Alexander Brown <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinMroz AustinMroz AustinMroz left review comments

@christian-byrne christian-byrne christian-byrne approved these changes

@webfiltered webfiltered webfiltered left review comments

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

Assignees
No one assigned
Labels
1.27 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch New Browser Test Expectations New browser test screenshot should be set by github action size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DrJKL @AustinMroz @christian-byrne @webfiltered