Skip to content

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 21, 2025

Summary

Don't route events up through GraphCanvas if the component itself can handle the changes

Changes

  • What: Reduce the indirect access or action dispatch to composables/stores.

Review Focus

The behavior should be either equivalent or a little snappier than before. Also, the local state in LGraphNode has (almost) all been removed in favor of reacting to the nodeData prop.

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested review from a team as code owners September 21, 2025 00:25
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 21, 2025
Copy link

github-actions bot commented Sep 21, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/21/2025, 05:03:07 AM UTC

📈 Summary

  • Total Tests: 454
  • Passed: 425 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 418 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

@christian-byrne
Copy link
Contributor

Is the test failure expected?

@DrJKL
Copy link
Contributor Author

DrJKL commented Sep 21, 2025

Is the test failure expected?

Nope, need to unwrap it in the test expectation.

@DrJKL
Copy link
Contributor Author

DrJKL commented Sep 21, 2025

Is the test failure expected?

Fixed 😊

@DrJKL DrJKL merged commit c4c0e52 into main Sep 21, 2025
21 checks passed
@DrJKL DrJKL deleted the drjkl/feat/note-node-2 branch September 21, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:vue-migration size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants