-
Notifications
You must be signed in to change notification settings - Fork 374
Refactor: Let LGraphNode handle more events itself #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/21/2025, 05:03:07 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Is the test failure expected? |
Nope, need to unwrap it in the test expectation. |
Fixed 😊 |
Summary
Don't route events up through GraphCanvas if the component itself can handle the changes
Changes
Review Focus
The behavior should be either equivalent or a little snappier than before. Also, the local state in LGraphNode has (almost) all been removed in favor of reacting to the nodeData prop.
┆Issue is synchronized with this Notion page by Unito