Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 19, 2025

Summary

Removed the informational "Use Legacy UI" tag from the ManagerHeader component while preserving all underlying legacy manager functionality.

Changes

  • What: Removed Tag component displaying legacy UI information from ManagerHeader
  • Breaking: None - all legacy manager functionality remains intact
  • Dependencies: None

Review Focus

Visual cleanup only - the --enable-manager-legacy-ui CLI flag and all related functionality continues to work normally. Only the informational UI tag has been removed from the header.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 19, 2025
Copy link

github-actions bot commented Sep 19, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/19/2025, 08:58:04 AM UTC

📈 Summary

  • Total Tests: 450
  • Passed: 421 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 414 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne
Copy link
Contributor Author

christian-byrne commented Sep 19, 2025

Oops, was only supposed to remove the UI component, not change any of the business logic. fixed now

Removes the informational 'Use Legacy UI' tag and tooltip from the ManagerHeader component.

The tag was displayed to inform users about the --enable-manager-legacy-ui flag option, but this UI element is no longer needed while preserving all underlying legacy manager functionality.

Changes:
- Remove Tag component and related div from ManagerHeader.vue template
- Remove unused Tag import from script section
- Update component tests to reflect simplified header structure
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 19, 2025
@christian-byrne christian-byrne merged commit 4f5bbe0 into main Sep 19, 2025
29 checks passed
@christian-byrne christian-byrne deleted the remove-legacy-manager-ui branch September 19, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manager size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants