lint: add tsconfig for browser_tests, fix existing violations #5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/18/2025, 05:29:45 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
webfiltered
previously approved these changes
Sep 18, 2025
dosubot
bot
added
size:L
(Where is |
In another repo. *nods* |
webfiltered
approved these changes
Sep 18, 2025
tests-ui/tsconfig.json
Outdated
| @@ -0,0 +1,14 @@ | |||
| { | |||
| // "extends": "../tsconfig.json", | |||
There was a problem hiding this comment.
Shouldn't need, or doesn't work? Curiosity only.
There was a problem hiding this comment.
Need for the editor/LSP, but funnily enough works otherwise.
DrJKL
force-pushed
the
drjkl/feat/note-node
branch
from
8224113 to
ae44715
Compare
arjansingh
approved these changes
Sep 18, 2025
Myestery
pushed a commit
that referenced
this pull request
Sep 19, 2025
## Summary See https://typescript-eslint.io/blog/project-service/ for context. Creates a browser_tests specific tsconfig so that they can be linted. Does not add a package.json script to do the linting yet, but `pnpm exec eslint browser_tests` should work for now. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5633-lint-add-tsconfig-for-browser_tests-fix-existing-violations-2726d73d3650819d8ef2c4b0abc31e14) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See https://typescript-eslint.io/blog/project-service/ for context.
Creates a browser_tests specific tsconfig so that they can be linted.
Does not add a package.json script to do the linting yet, but
pnpm exec eslint browser_testsshould work for now.┆Issue is synchronized with this Notion page by Unito