Skip to content

Conversation

benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Sep 15, 2025

Summary

Fixes FE types publishing workflow because it wanted to publish from master/main default but we allowed postmortem publishing, RC branch publishing, and just generally whatever hash publishing

Also stops from automatically downloading playwright browsers since they're not needed.

Changes

  • What: Adds --no-git-checks and PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner September 15, 2025 22:58
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@benceruleanlu benceruleanlu changed the title Add --no-git-checks and ignore playwright Fix FE types publishing workflow Sep 15, 2025
Copy link

github-actions bot commented Sep 15, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/15/2025, 11:09:48 PM UTC

📈 Summary

  • Total Tests: 450
  • Passed: 421 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 414 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit ede43c5 into main Sep 17, 2025
25 checks passed
@christian-byrne christian-byrne deleted the bl-fix-FE-types-publish branch September 17, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI/CD size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants