Skip to content

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 15, 2025

Summary

Instrument mode to trigger node data updates.

Changes

  • What: Makes bypass/mute work immediately on the Vue nodes

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested a review from a team as a code owner September 15, 2025 21:57
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 15, 2025
Copy link

github-actions bot commented Sep 15, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/15/2025, 11:27:28 PM UTC

📈 Summary

  • Total Tests: 448
  • Passed: 417 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 410 / ❌ 0 / ⚠️ 2 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

AustinMroz
AustinMroz previously approved these changes Sep 15, 2025
Copy link
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR that solves the specific problem advertised, but uncovers a strange and related issue: If a single node is selected after swapping to vue mode, pressing the bypass keybind does not cause the state to toggle. The associated function in useCoreCommands isn't even called.

Excluding the missed log, everything else is functional and beautiful

@AustinMroz AustinMroz assigned DrJKL and unassigned AustinMroz Sep 15, 2025
})
break
case 'mode':
console.log('Do the thing')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem very descriptive or helpful, WDYT about removing this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am deeply ashamed.

Copy link
Member

@benceruleanlu benceruleanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated as well?

it('should initialize with default tracked properties', () => {
const propManager = new LGraphNodeProperties(mockNode)
const tracked = propManager.getTrackedProperties()
expect(tracked).toHaveLength(2)
expect(tracked).toContain('title')
expect(tracked).toContain('flags.collapsed')
})

Copy link
Member

@benceruleanlu benceruleanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't even know if that test is ran though, I had assumed litegraph tests were enabled some time ago, but if it's not complaining and CI is green then I think it should be fine for now until the tests are enabled later

@DrJKL
Copy link
Contributor Author

DrJKL commented Sep 15, 2025

Another great PR that solves the specific problem advertised, but uncovers a strange and related issue: If a single node is selected after swapping to vue mode, pressing the bypass keybind does not cause the state to toggle. The associated function in useCoreCommands isn't even called.

Excluding the missed log, everything else is functional and beautiful

Mind if I investigate that as a separate issue? I feel like it'll probably be a more involved fix (and maybe cover a few more scenarios)

@DrJKL DrJKL assigned AustinMroz and unassigned DrJKL Sep 15, 2025
Copy link
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my intent, yes. The code here is good.

@christian-byrne christian-byrne merged commit 4f8e820 into main Sep 16, 2025
21 checks passed
@christian-byrne christian-byrne deleted the drjkl/bypass-updates branch September 16, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants