[fix] add focus state and aria to select components #5596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjansingh
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
dosubot
bot
added
the
size:XL
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/15/2025, 09:49:58 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
previously approved these changes
Sep 15, 2025
| selectedCount.value > 0 | ||
| ? 'border-blue-400 dark-theme:border-blue-500' | ||
| : 'border-transparent', | ||
| 'focus-within:border-blue-400 dark-theme:focus-within:border-blue-500', |
There was a problem hiding this comment.
The border color is being set in two places. It makes sense that focus-within would take precedence.
Want to wrap this in a cn() to make sure the options merge in order?
There was a problem hiding this comment.
Actually, it's a little weird that we'd have focus states on both the trigger and the menu item...
DrJKL
approved these changes
Sep 15, 2025
christian-byrne
approved these changes
Sep 15, 2025
arjansingh
force-pushed
the
feat/multiselect-singleselect-accessibility
branch
from
576d0e3 to
eadbaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Focus states weren't working, especially when trying to use the selects with
TABindexes and your keyboard.Changes
Screenshots
Demo of working focus states:
MultiSelect-2025-09-15.mov
SingleSelect-2025-09-15.mov
┆Issue is synchronized with this Notion page by Unito