Skip to content

Conversation

jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Sep 15, 2025

Summary

new design for left click and wheel to allow user set behavior:

  1. Use left click to drag vs select
  2. Use scroll wheel to zoom vs Pan

Add a new section at the top of the "Lite Graph" tab called Canvas Navigation
Move there the navigation modes settings -> this one still just has two mode to select from
These settings have settings that:

  1. change their values depending on which mode is selected
  2. can be overwritten. So if the user selects a combo that is not from the standard nor from the drag mode at the nav mode drop down we will set the text to "custom"
image

Changes

  • What: add two new settings, LeftMouseClickBehavior and MouseWheelScroll
  • Breaking: on LiteGraph, we would not use canvasNavigationMode properties to control behavior

Screenshots (if applicable)

2025-09-14.09-21-42.mp4

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 15, 2025
Copy link

github-actions bot commented Sep 15, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 09/17/2025, 02:32:26 AM UTC

📈 Summary

  • Total Tests: 448
  • Passed: 417 ✅
  • Failed: 1 ❌
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 410 / ❌ 1 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@CoreyCorza
Copy link

Words cannot express how much this pr means to me

@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Sep 15, 2025

@CoreyCorza this is something requested by Pablo in slack directly, I am still waiting for his test results, sorry I don’t add too much design details yet, let me convert this into draft for now

@jtydhr88 jtydhr88 marked this pull request as draft September 15, 2025 08:45
@jtydhr88 jtydhr88 marked this pull request as ready for review September 16, 2025 19:40
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the inline imports in the onChange callbacks?

@jtydhr88 jtydhr88 added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 17, 2025
@jtydhr88
Copy link
Collaborator Author

I checked the current screenshots, likely they are incorrect, I need to update them

@christian-byrne
Copy link
Contributor

Yeah, the old ones seemed incorrect as they were zoomed in. The new images show the same zoom level but the canvas is shifted to the left slightly, which seems to match test case description "Shift + mouse wheel should pan canvas horizontally", is that accurate?

image

@christian-byrne christian-byrne merged commit 6866e12 into main Sep 17, 2025
2 checks passed
@christian-byrne christian-byrne deleted the nav-mode2 branch September 17, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:navigation area:settings New Browser Test Expectations New browser test screenshot should be set by github action size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants