[test] Add component test for TreeSelect Vue widget
#5551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/16/2025, 09:33:17 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
force-pushed
the
vue-nodes/test/tree-select-widget-test
branch
from
502da31 to
cac6599
Compare
DrJKL
previously approved these changes
Sep 16, 2025
Comment on lines
11
to
18
| type TreeNode = { | ||
| key: string | ||
| label?: string | ||
| data?: unknown | ||
| children?: TreeNode[] | ||
| leaf?: boolean | ||
| selectable?: boolean | ||
| } |
There was a problem hiding this comment.
Same question as in the imagecompare PR, is this type available from within the component code?
There was a problem hiding this comment.
Exported TreeNode type from component in 45dfb55
Comment on lines
21
to
120
| const createMockWidget = ( | ||
| value: WidgetValue = null, | ||
| options: Partial<TreeSelectProps> = {}, | ||
| callback?: (value: WidgetValue) => void | ||
| ): SimplifiedWidget<WidgetValue> => ({ | ||
| name: 'test_treeselect', | ||
| type: 'object', | ||
| value, | ||
| options, | ||
| callback | ||
| }) | ||
|
|
||
| const mountComponent = ( | ||
| widget: SimplifiedWidget<WidgetValue>, | ||
| modelValue: WidgetValue, | ||
| readonly = false | ||
| ) => { | ||
| return mount(WidgetTreeSelect, { | ||
| global: { | ||
| plugins: [PrimeVue], | ||
| components: { TreeSelect } | ||
| }, | ||
| props: { | ||
| widget, | ||
| modelValue, | ||
| readonly | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| const setTreeSelectValueAndEmit = async ( | ||
| wrapper: ReturnType<typeof mount>, | ||
| value: unknown | ||
| ) => { | ||
| const treeSelect = wrapper.findComponent({ name: 'TreeSelect' }) | ||
| await treeSelect.vm.$emit('update:modelValue', value) | ||
| return treeSelect | ||
| } | ||
|
|
||
| const createTreeData = (): TreeNode[] => [ | ||
| { | ||
| key: '0', | ||
| label: 'Documents', | ||
| data: 'Documents Folder', | ||
| children: [ | ||
| { | ||
| key: '0-0', | ||
| label: 'Work', | ||
| data: 'Work Folder', | ||
| children: [ | ||
| { | ||
| key: '0-0-0', | ||
| label: 'Expenses.doc', | ||
| data: 'Expenses Document', | ||
| leaf: true | ||
| }, | ||
| { | ||
| key: '0-0-1', | ||
| label: 'Resume.doc', | ||
| data: 'Resume Document', | ||
| leaf: true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| key: '0-1', | ||
| label: 'Home', | ||
| data: 'Home Folder', | ||
| children: [ | ||
| { | ||
| key: '0-1-0', | ||
| label: 'Invoices.txt', | ||
| data: 'Invoices for this month', | ||
| leaf: true | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| key: '1', | ||
| label: 'Events', | ||
| data: 'Events Folder', | ||
| children: [ | ||
| { key: '1-0', label: 'Meeting', data: 'Meeting', leaf: true }, | ||
| { | ||
| key: '1-1', | ||
| label: 'Product Launch', | ||
| data: 'Product Launch', | ||
| leaf: true | ||
| }, | ||
| { | ||
| key: '1-2', | ||
| label: 'Report Review', | ||
| data: 'Report Review', | ||
| leaf: true | ||
| } | ||
| ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
Nit: Please move to module scope.
There was a problem hiding this comment.
Moved to module scope in 4674a7d
…dback Co-authored-by: DrJKL <[email protected]>
…dback Co-authored-by: DrJKL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive test suite for WidgetTreeSelect component with 32 test cases covering tree navigation, selection modes, and edge cases.
Changes
Review Focus
Test coverage for deeply nested tree structures, special character handling, and proper Vue event emission patterns. Verify mock widget creation follows existing patterns.
┆Issue is synchronized with this Notion page by Unito