Skip to content

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Sep 13, 2025

Summary

Adds the Inter fonts used in Figma designs.

Changes

Review Focus

  • Is this idiomatic Tailwind?

Screenshots (if applicable)

Inter font, weight 700, 30px.

font-inter font-bold text-3xl
image

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner September 13, 2025 14:16
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 13, 2025
Copy link

github-actions bot commented Sep 13, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/16/2025, 05:05:30 PM UTC

📈 Summary

  • Total Tests: 449
  • Passed: 419 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 412 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

AustinMroz
AustinMroz previously approved these changes Sep 13, 2025
@christian-byrne
Copy link
Contributor

This would essentially be the first non-permissive-license asset or library we add, right?

@webfiltered
Copy link
Contributor Author

To my knowledge, yes.

Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these to our theme in style.css?

@DrJKL
Copy link
Contributor

DrJKL commented Sep 13, 2025

Oh, you an also import the fonts in style.css instead of in main.ts.

DrJKL
DrJKL previously approved these changes Sep 13, 2025
Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@webfiltered webfiltered changed the title Add ABC ROM fonts used by Figma designs Add Inter font used by Figma designs Sep 15, 2025
@webfiltered
Copy link
Contributor Author

webfiltered commented Sep 15, 2025

@christian-byrne Had a chat w/ @PabloWiedemann about this. He decided to update all the designs to use Inter - which is under SIL OFL. All the OSS boxes ticked. 👍

DrJKL
DrJKL previously approved these changes Sep 16, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 16, 2025
@christian-byrne christian-byrne merged commit 4ff18fd into main Sep 16, 2025
25 checks passed
@christian-byrne christian-byrne deleted the add-fonts branch September 16, 2025 17:31
@christian-byrne
Copy link
Contributor

@christian-byrne Had a chat w/ @PabloWiedemann about this. He decided to update all the designs to use Inter - which is under SIL OFL. All the OSS boxes ticked. 👍

Thanks you guys are amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants