Skip to content

Conversation

marawan206
Copy link

@marawan206 marawan206 commented Sep 13, 2025

update the SHA in the tests-ui github actions to use the new ComfyUI_devtools commit

┆Issue is synchronized with this Notion page by Unito

@marawan206 marawan206 requested a review from a team as a code owner September 13, 2025 10:19
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 13, 2025
Copy link

github-actions bot commented Sep 13, 2025

🎭 Playwright Test Results

loading Tests are starting...

⏰ Started at: 09/15/2025, 11:22:51 PM UTC

🚀 Running Tests

  • 🧪 chromium: Running tests...
  • 🧪 chromium-0.5x: Running tests...
  • 🧪 chromium-2x: Running tests...
  • 🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running...

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as well:

ref: 'd05fd48dd787a4192e16802d4244cfcc0e2f9684'

@DrJKL
Copy link
Contributor

DrJKL commented Sep 13, 2025

Is the default branch not on the latest version?

@christian-byrne
Copy link
Contributor

Pinning just allows updating in specific order and better security, I guess.

@christian-byrne
Copy link
Contributor

By "updating in specific order" I mean, if you change the devtools nodes and it's not pinned, CI in the frontend can start to unexpectedly fail until tests are changed (if necessary). Another reason for

@christian-byrne
Copy link
Contributor

This test case fails:

    Test timeout of 15000ms exceeded.

    Error: locator.click: Test timeout of 15000ms exceeded.
    Call log:
      - waiting for locator('.p-tree-node-content:has(> .tree-explorer-node-label:has(.tree-leaf .node-label:has-text("Remote Widget Node With Refresh Button and Control After Refresh")))').first()


      16 |     const nodeEntry = tab.getNode(nodeName).first()
      17 |     for (let i = 0; i < count; i++) {
    > 18 |       await nodeEntry.click()
         |                       ^
      19 |       await comfyPage.nextFrame()
      20 |     }
      21 |   }
        at addRemoteWidgetNode (/home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/browser_tests/tests/remoteWidgets.spec.ts:18:23)
        at /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/browser_tests/tests/remoteWidgets.spec.ts:328:7

    Error Context: test-results/tests-remoteWidgets-Remote-c1324-sh-is-applied-after-refresh-chromium-retry3/error-context.md

  1 failed
    [chromium] › browser_tests/tests/remoteWidgets.spec.ts:306:5 › Remote COMBO Widget › Refresh Behavior › control_after_refresh is applied after refresh 

Likely will be fixed by

@DrJKL
Copy link
Contributor

DrJKL commented Sep 23, 2025

#5166

@DrJKL DrJKL closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI/CD size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants