-
Notifications
You must be signed in to change notification settings - Fork 377
ci(tests-ui): pin ComfyUI_devtools #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one as well:
ref: 'd05fd48dd787a4192e16802d4244cfcc0e2f9684' |
Is the default branch not on the latest version? |
Pinning just allows updating in specific order and better security, I guess. |
By "updating in specific order" I mean, if you change the devtools nodes and it's not pinned, CI in the frontend can start to unexpectedly fail until tests are changed (if necessary). Another reason for |
This test case fails:
Likely will be fixed by |
update the SHA in the tests-ui github actions to use the new ComfyUI_devtools commit
┆Issue is synchronized with this Notion page by Unito