Skip to content

Conversation

DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 7, 2025

…to the containing node.

Summary

stopPropagation on pointer events in the widget wrapper.

Changes

  • What: Keeps the nodes from moving when dragging the slider thumb.

Review Focus

Try it out before and after.

Demo

Before

Screen.Recording.2025-09-07.154355.mp4

After

Screen.Recording.2025-09-07.154611.mp4

@DrJKL DrJKL requested a review from a team as a code owner September 7, 2025 22:41
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 7, 2025
Copy link

github-actions bot commented Sep 7, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/07/2025, 10:51:20 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christian-byrne christian-byrne merged commit 6c7adf9 into main Sep 8, 2025
27 checks passed
@christian-byrne christian-byrne deleted the drjkl/fix/slider-too-slidey branch September 8, 2025 01:45
snomiao pushed a commit that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:vue-migration size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants