Skip to content

[backport 1.25] Deep copy subgraphs to clipboard, update nested ids on paste #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[backport 1.25] Deep copy subgraphs to clipboard, update nested ids on paste #5022

merged 1 commit into from
Aug 15, 2025

Conversation

comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Aug 15, 2025 •
edited by sync-by-unito bot
Loading

Backport of #5003 to core/1.25

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@AustinMroz @github-actions
Deep copy subgraphs to clipboard, update nested ids on paste (#5003)
7c2f49b 
* Deep copy to clipboard, update nested ids on paste

The copyToClipboard function wasn't walking subgraphs and leaving nested
subgraphs unserialized. This has now been fixed.

This requires that equivalent support be added to _pasteFromClipboard to
update the ids of nested subgraphs which are pasted.

* Add extra advisory comments
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner August 15, 2025 21:03
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 15, 2025
@comfy-pr-bot comfy-pr-bot mentioned this pull request Aug 15, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

⚠️ Warnings

⚠️ Warning: E2E Test Coverage Missing

If this PR modifies behavior that can be covered by browser-based E2E tests, those tests are required. PRs lacking applicable test coverage may not be reviewed until added. Please add or update browser tests to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.
You can add it by:

  • GitHub: Drag & drop media directly into the PR description

  • YouTube: Include a link to a short demo

@christian-byrne
Copy link
Contributor

Test failed due to network error

npm warn deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated [email protected]: Use your platform's native DOMException instead
npm warn deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm error code ECONNRESET
npm error network aborted
npm error network This is a problem related to network connectivity.
npm error network In most cases you are behind a proxy or have bad network settings.
npm error network
npm error network If you are behind a proxy, please make sure that the
npm error network 'proxy' config is set properly.  See: 'npm help config'
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/202[5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/16999346743/job/48197646977?pr=5022#step:4:6)-08-15T21_04_02_933Z-debug-0.log

@christian-byrne christian-byrne merged commit a7cbf1b into core/1.25 Aug 15, 2025
14 of 15 checks passed
@christian-byrne christian-byrne deleted the backport-5003-to-1.25 branch August 15, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Backporting a PR onto a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comfy-pr-bot @christian-byrne @AustinMroz