Opensearch api support #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
reviewed
Sep 15, 2025
There was a problem hiding this comment.
Looks good overall, I'd say.
But this would also need to be implemented for cogstack2.py:
https://github.com/CogStack/working_with_cogstack/blob/main/cogstack2.py
Annoying, I know. But for now, there's 2 different modules for ES/OS stuff.
Furthermore, it would need to be implemented into the cogstac-nlp PR as well:
|
starting doing this, but then thought are we going to refactor this anyway, and remove the dupe in due course? |
|
Yeah, fair enough. Just need to make sure this doesn't slip through the cracks! |
|
I think I can cancel this, as you've replicated the change to |
|
Yes, that's fair. But I'd leave the branch so we can refer to it if/when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal set of changes to support OpenSearch in working_with_cogstack.
This ideally needs an integration test with an Elastic and an OpenSearch service