Skip to content

Conversation

Amarta113
Copy link

This PR fixes #4614

Changes Details:

  • Corrected the handling of the urlFields during profile updates.

  • Ensured that updates to First Name, Last Name, and Affiliation fields work correctly without triggering an error.

  • Verified that other fields like username and social links continue to update properly.

Testing Done:

  • Manually tested updating each of the affected fields individually and together.

  • Confirmed that the error no longer appears and that the profile updates successfully.

Output Picture:

image

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.63%. Comparing base (96968d6) to head (a2da28b).
Report is 1183 commits behind head on master.

Files with missing lines Patch % Lines
frontend/src/js/controllers/profileCtrl.js 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4629      +/-   ##
==========================================
- Coverage   72.93%   69.63%   -3.30%     
==========================================
  Files          83       21      -62     
  Lines        5368     3610    -1758     
==========================================
- Hits         3915     2514    -1401     
+ Misses       1453     1096     -357     
Files with missing lines Coverage Δ
frontend/src/js/controllers/profileCtrl.js 65.42% <33.33%> (-27.44%) ⬇️

... and 65 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/profileCtrl.js 65.42% <33.33%> (-27.44%) ⬇️

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1444f...a2da28b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RishabhJain2018
Copy link
Member

Thanks @Amarta113 for the fix!

@Amarta113
Copy link
Author

Hi @RishabhJain2018, thank you for reviewing and approving the PR. I noticed that merging is currently blocked due to authorization. Could you please advise on how to proceed?

@RishabhJain2018
Copy link
Member

:) You can't merge the PR. I'll merge it.

@Amarta113
Copy link
Author

Hey @RishabhJain2018 is it ready to merge or do i need any changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect URL Validation on First Name, Last Name and Affiliation section
2 participants